Skip to content

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

The RL script still used the previous notation of python modules using numbers. Remove them.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
@j-rivero j-rivero requested a review from mjcarroll as a code owner July 22, 2025 18:34
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Jul 22, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jul 22, 2025
@j-rivero j-rivero merged commit 0172411 into main Jul 23, 2025
10 checks passed
@j-rivero j-rivero deleted the jrivero/rl_python_update branch July 23, 2025 10:17
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jul 23, 2025
j-rivero added a commit to j-rivero/nightly_gz_sim_reinforce_learning that referenced this pull request Jul 23, 2025
gazebosim/gz-sim#2989 was merged, no need for a custom branch anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants