Skip to content

Conversation

XINJIANGMO
Copy link
Contributor

🦟 Bug fix

Fixes #2954

Summary

The plugin could crash when the render engine fails to load and scene is not initialized.
This commit adds a guard to ensure only Render events are processed before scene is ready.

Checklist

  • Signed all commits for DCO
  • Added test
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

…crash on render engine failure

Signed-off-by: momo <2438833481@qq.com>
Signed-off-by: momo <2438833481@qq.com>
@XINJIANGMO XINJIANGMO requested a review from mjcarroll as a code owner July 8, 2025 10:07
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 8, 2025
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jul 8, 2025
Signed-off-by: momo <2438833481@qq.com>
@XINJIANGMO XINJIANGMO requested a review from ahcorde July 8, 2025 11:43
@ahcorde ahcorde requested a review from iche033 July 8, 2025 12:00
@iche033 iche033 merged commit 6f56f87 into gazebosim:gz-sim9 Jul 8, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Crash when clicking entity tree in GUI after loading invalid render engine

3 participants