Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 19, 2025

🎉 New feature

Depends on gazebosim/gz-common#680

Summary

Removed and replaced duplicate code for loading heightmap data with the new utility functions added in gz-common: gazebosim/gz-common#680.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested review from azeey and mjcarroll as code owners May 19, 2025 23:15
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label May 19, 2025
@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label May 19, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 20, 2025
@iche033
Copy link
Contributor Author

iche033 commented Jun 2, 2025

@osrf-jenkins run tests please

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 force-pushed the iche033/heightmap_loader branch from 16c7b10 to e0f9323 Compare June 2, 2025 22:06
@iche033 iche033 changed the base branch from main to gz-sim9 June 2, 2025 22:06
@iche033 iche033 added 🏛️ ionic Gazebo Ionic and removed needs upstream release Blocked by a release of an upstream library 🪵 jetty Gazebo Jetty labels Jun 2, 2025
@iche033 iche033 merged commit 5d48cd7 into gz-sim9 Jun 3, 2025
9 of 11 checks passed
@iche033 iche033 deleted the iche033/heightmap_loader branch June 3, 2025 00:01
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants