Fix Qt warnings on shutdown #2898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2871
Summary
This fixes the Qt warnings when closing gz sim.
More info:
When a plugin with TreeView is closed, we see warnings about failing to disconnect Qt signals / slots. This is because the tree model used by the TreeView is already destroyed by Qt so the TreeView fails to disconnect their signals / slots. This fix is to manually disconnect all these signals and slots in the tree model destructor so that when deleting the TreeView, it no longer attempts to disconnect them again.
Quick Test:
Launch
gz sim -v 4 shapes.sdf, close the window -> you should no longer see Qt warnings like:Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.