Skip to content

Set GZ_IP=127.0.0.1 in gz cmd tests #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Set GZ_IP=127.0.0.1 in gz cmd tests #2884

merged 1 commit into from
Apr 28, 2025

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes some tests using a cherry-pick from #2857

Summary

This cherry-picks 93f25a4 from #2857 to fix gz cmd test failures.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Set GZ_IP=127.0.0.1 in gz cmd tests
9dac51b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 28, 2025
@scpeters scpeters marked this pull request as ready for review April 28, 2025 04:08
@scpeters scpeters requested a review from mjcarroll as a code owner April 28, 2025 04:08
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 28, 2025
@scpeters scpeters merged commit 3f40ef2 into gz-sim9 Apr 28, 2025
10 of 11 checks passed
@scpeters scpeters deleted the scpeters/fix_gz_cmd_tests_macos branch April 28, 2025 17:29
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 28, 2025
@scpeters
Copy link
Member Author

https://github.com/Mergifyio backport gz-sim8

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2025 •
edited
Loading

backport gz-sim8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 28, 2025
@scpeters @mergify
Set GZ_IP=127.0.0.1 in gz cmd tests (#2884)
254942e 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 3f40ef2)

# Conflicts:
#	src/cmd/CMakeLists.txt
@mergify mergify bot mentioned this pull request Apr 28, 2025
Closed
8 tasks
@scpeters scpeters mentioned this pull request Apr 28, 2025
Merged
8 tasks
@scpeters
Copy link
Member Author

we can manually backport this to fortress by setting IGN_IP

scpeters added a commit that referenced this pull request Jun 25, 2025
@scpeters
Set IGN_IP=127.0.0.1 in cmd tests
225454f 
Manual backport of #2884.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Jun 25, 2025
Merged
9 tasks
scpeters added a commit that referenced this pull request Jun 26, 2025
@scpeters
Set IGN_IP=127.0.0.1 in cmd tests (#2959)
5e31757 
Manual backport of #2884.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iche033 iche033 iche033 approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

No one assigned

Labels

🏛️ ionic Gazebo Ionic

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scpeters @iche033