Skip to content

Fix airspeed calculation under wind influence by wind triangle #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 7, 2025
Merged

Fix airspeed calculation under wind influence by wind triangle #2844

merged 11 commits into from
Jul 7, 2025

Conversation

TigerWuu
Copy link
Contributor

@TigerWuu TigerWuu commented Apr 2, 2025 •
edited
Loading

🦟 Bug fix

Result from the discussion in PX4/PX4-Autopilot#24452
Depends on

Summary

Refer to windEffect plugin, the airspeed plugin obtains wind information through ECM and transmits it to the airspeed sensor to calculate true airspeed considering wind influence, which is by calling SetWindVelocity function.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@TigerWuu
FIX: airspeed calculation by tranmitting wind information into airspe…
9d43d63 
…ed sensor

Signed-off-by: TigerWuu <tiger871108@gmail.com>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 2, 2025
@TigerWuu TigerWuu marked this pull request as ready for review April 2, 2025 16:38
@TigerWuu TigerWuu requested a review from mjcarroll as a code owner April 2, 2025 16:38
ahcorde
ahcorde requested changes Apr 2, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 2, 2025
@TigerWuu
MOD: restore unrelated modification
b801a07 
Signed-off-by: TigerWuu <tiger871108@gmail.com>
@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label Apr 10, 2025
iche033
iche033 reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me. This needs a gz-sensors9 release for CI to be green

iche033
iche033 reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gz-sensors9 was released last week. This PR is good to go. Just a couple of minor issues picked up by CI

@iche033 iche033 removed the needs upstream release Blocked by a release of an upstream library label Jul 1, 2025
TigerWuu and others added 2 commits July 2, 2025 13:08
@TigerWuu @iche033
Update src/systems/air_speed/AirSpeed.cc
efe2262 
Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ching-Hsiang Wu <tiger871108@gmail.com>
@TigerWuu @iche033
Update src/systems/air_speed/AirSpeed.cc
f74137f 
Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ching-Hsiang Wu <tiger871108@gmail.com>
@TigerWuu TigerWuu requested a review from iche033 July 2, 2025 08:03
iche033
iche033 reviewed Jul 2, 2025
View reviewed changes
@TigerWuu @iche033
Update src/systems/air_speed/AirSpeed.cc
7bfd1bb 
Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ching-Hsiang Wu <tiger871108@gmail.com>
@TigerWuu TigerWuu requested review from ahcorde and iche033 July 2, 2025 17:36
@iche033 iche033 merged commit c1accc3 into gazebosim:gz-sim9 Jul 7, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jul 7, 2025
@TigerWuu TigerWuu deleted the pr_fix_airspeedsensor branch July 8, 2025 05:03
@msberk msberk mentioned this pull request Sep 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@iche033 iche033 Awaiting requested review from iche033

Assignees

No one assigned

Labels

🏛️ ionic Gazebo Ionic

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TigerWuu @ahcorde @iche033