Skip to content

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to #2776

Summary

We vendored backward-cpp in #2776 to use in integration tests, but I noticed while investigating an unstable nightly build that some vendored files are being installed with gz-sim. I don't think these should be installed with our packages, so I am modifying the cmake logic to prevent their installation here.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 28, 2025
@j-rivero
Copy link
Contributor

The patch works although it is fragile if at some point we update the version of the backward vendor copy. Since the effects of installing the files are not severe I'm inclined to to merge the change.

An alternative would be to deal with file removal in packaging but the problem is not solve for source compilations and we scale the size of the problem to many packaging platforms.

@j-rivero j-rivero merged commit 47203d0 into gz-sim9 Mar 29, 2025
10 of 12 checks passed
@j-rivero j-rivero deleted the scpeters/no_install_backward branch March 29, 2025 08:56
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants