Skip to content

Migrate to Qt6 #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 19, 2025
Merged

Migrate to Qt6 #2832

merged 21 commits into from
Apr 19, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 25, 2025 •
edited
Loading

🎉 New feature

Built on top of #2797 (and replaces that PR)

Depends on gazebosim/gz-gui#666

Summary

Changes are similar to to what's done in gazebosim/gz-gui#666.

CI Status

Needs to get gazebosim/gz-gui#666 in first.

Depends on:

Plugins / Examples Status

I tested all gui plugins and examples in gz-sim (on ubuntu) to make sure they work in Qt6. Here are their statuses:

Plugins

  • align_tool
  • apply_force_torque
  • banana_for_scale
  • component_inspector
  • component_inspector_editor
  • copy_paste
  • entity_context_menu
  • entity_tree
  • environment_loader
  • environment_visualization
  • global_illumination_civct
  • global_illumination_vct
  • joint_position_controller
  • lights
  • mouse_drag
  • playback_scrubber
  • plot_3d
  • plotting
  • resource_spawner
  • scene_manager
  • select_entities
  • shapes
  • spawn
  • transform_control
  • video_recorder
  • view_angle
  • visualization_capabilities
  • visualize_contacts
  • visualize_frustum
  • visualize_lidar

Examples

  • gui_system_plugin
  • rendering_plugins

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey added 6 commits February 22, 2025 00:31
@azeey
Use a stored SerializedStepMap message instead of passing it as a f…
b2ffebc 
…unction argument

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
WIP qml
dd32d72 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
WIP qml
a6e2fbd 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
WIP qml
2c98ce6 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
WIP
203b970 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Update packages.apt
d36cfab 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@iche033 iche033 requested a review from mjcarroll as a code owner March 25, 2025 21:02
@iche033 iche033 marked this pull request as draft March 25, 2025 21:02
@iche033
fixes for entity tree, file dialogs, qml to copp prop context bindings
e53d910 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 added 6 commits March 26, 2025 21:21
@iche033
Revert "Use a stored SerializedStepMap message instead of passing i…
39a9266 
…t as a function argument"

This reverts commit b2ffebc.
@iche033
Fix registering gz::msgs::SerializedStepMap
0bcf007 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fix entity context menu, plotting pose from component inspector
c935323 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
update examples, fix warnings
3774ce6 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fix warnings, workaround modal dialog widths
e1c5716 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Merge branch 'main' into iche033/qt6
ead0c00
@iche033 iche033 changed the base branch from azeey/qt6_simple to main April 9, 2025 23:17
@iche033 iche033 changed the title More Qt6 changes Migrate to Qt6 Apr 9, 2025
@iche033
whitespace
0e07fa6 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from caguero April 9, 2025 23:23
@iche033 iche033 marked this pull request as ready for review April 9, 2025 23:23
@iche033 iche033 requested a review from jennuine as a code owner April 9, 2025 23:23
@iche033 iche033 mentioned this pull request Apr 14, 2025
Merged
43 tasks
caguero
caguero reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a reproducible crash loading the "Visualize Frustum" plugin. For reference, I'm testing loading the shapes.sdf world.

caguero
caguero reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the plugins worked for me except the crash on the plugin that I mentioned. Looking great!

iche033 added 2 commits April 18, 2025 17:01
@iche033
Merge branch 'main' into iche033/qt6
0b8eba6
@iche033
fix visualize frustum gui plugin
6762f63 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Apr 18, 2025

I got a reproducible crash loading the "Visualize Frustum" plugin. For reference, I'm testing loading the shapes.sdf world.

oh missed that one. Just merged with main, and updated that plugin in 6762f63

@iche033 iche033 mentioned this pull request Apr 18, 2025
Merged
@caguero
Copy link
Contributor

caguero commented Apr 18, 2025

I got a reproducible crash loading the "Visualize Frustum" plugin. For reference, I'm testing loading the shapes.sdf world.

oh missed that one. Just merged with main, and updated that plugin in 6762f63

Fix confirmed!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 18, 2025
@iche033 iche033 mentioned this pull request Apr 18, 2025
Merged
iche033 added 5 commits April 19, 2025 00:09
@iche033
update dep
c1e38ac 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
testing fix
9d94c75 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
revert changes
6702d02 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fixing gui test
0d01b48 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
skip gui test for now
135affb 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Apr 19, 2025

disabled UNIT_Gui_TEST's QuickStart test as it's crashing when closing main window on Ubuntu CI. I can't reproduce locally but will investigate separately. Otherwise everything looks good. Merging!

@iche033 iche033 merged commit a7f35c6 into main Apr 19, 2025
6 of 8 checks passed
@iche033 iche033 deleted the iche033/qt6 branch April 19, 2025 07:39
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 19, 2025
This was referenced Apr 22, 2025
Merged
Closed
@azeey azeey mentioned this pull request Aug 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iche033 @caguero @azeey