-
Notifications
You must be signed in to change notification settings - Fork 342
Add velocity limits component (#2664) #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mo-zaghloul
wants to merge
8
commits into
gazebosim:gz-sim8
Choose a base branch
from
mo-zaghloul:add-joint-limit-methods
base: gz-sim8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
43c771f
Add velocity limits component and method to Joint class (#2664)
mo-zaghloul fc80807
Update copyright year in JointVelocityLimits component
mo-zaghloul 61f6477
Remove vscode config files
mo-zaghloul 2b3704a
Merge branch 'gz-sim8' into add-joint-limit-methods
mo-zaghloul 947ea5b
Refactor VelocityLimits method to return MaxVelocity from JointAxis c…
mo-zaghloul 2ff09ad
Merge branch 'add-joint-limit-methods' of https://github.com/mo-zaghl…
mo-zaghloul 2dc2aad
Merge branch 'gz-sim8' into add-joint-limit-methods
ahcorde 4256fc2
Merge branch 'gz-sim8' into add-joint-limit-methods
ahcorde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright (C) 2025 Open Source Robotics Foundation | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
#ifndef GZ_SIM_COMPONENTS_JOINTVELOCITYLIMITS_HH_ | ||
#define GZ_SIM_COMPONENTS_JOINTVELOCITYLIMITS_HH_ | ||
|
||
#include <vector> | ||
#include <gz/math/Vector2.hh> | ||
|
||
#include <gz/sim/components/Component.hh> | ||
#include <gz/sim/components/Factory.hh> | ||
#include <gz/sim/components/Serialization.hh> | ||
#include <gz/sim/config.hh> | ||
#include <gz/sim/Export.hh> | ||
|
||
namespace gz | ||
{ | ||
namespace sim | ||
{ | ||
// Inline bracket to help doxygen filtering. | ||
inline namespace GZ_SIM_VERSION_NAMESPACE { | ||
|
||
namespace components | ||
{ | ||
/// \brief Component for recording the current velocity limits of a joint. | ||
/// Data are a vector with a Vector2 for each DOF. The X() component of the | ||
/// Vector2 specifies the minimum velocity limit, the Y() component stands | ||
/// for maximum limit. | ||
using JointVelocityLimits = Component< | ||
std::vector<gz::math::Vector2d>, | ||
class JointVelocityLimitsTag, | ||
serializers::VectorSerializer<gz::math::Vector2d> | ||
>; | ||
|
||
GZ_SIM_REGISTER_COMPONENT( | ||
"gz_sim_components.JointVelocityLimits", JointVelocityLimits) | ||
} | ||
} | ||
} | ||
} | ||
|
||
#endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just get this information from the
JointAxis
component, e.g.For joint velocity, there is no lower or upper limit, but only just one velocity limit field