Fix crash when multicopter motor system is attached to an empty model #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
ahcorde
approved these changes
Oct 16, 2024
iche033
added a commit
that referenced
this pull request
Nov 4, 2024
…#2653) Signed-off-by: Ian Chen <ichen@openrobotics.org>
8 tasks
iche033
added a commit
that referenced
this pull request
Nov 4, 2024
…#2653) Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2646
Summary
See instructions in #2646 for reproducing the crash.
Crash happens because the multicopter motor system is not able to find the parent link name component of a joint but still tries to access the component data. Fixed by adding a check for null component.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.