Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 4, 2024

🦟 Bug fix

gazebosim/gz-gui#615 (comment)

Summary

Check to make sure the pose cmd value is finite and orientation is non-zero.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from azeey as a code owner October 4, 2024 17:49
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 4, 2024
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.86%. Comparing base (ab18888) to head (827afee).
Report is 124 commits behind head on gz-sim8.

Files with missing lines Patch % Lines
src/systems/physics/Physics.cc 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2640      +/-   ##
===========================================
+ Coverage    65.75%   68.86%   +3.10%     
===========================================
  Files          327      339      +12     
  Lines        31233    32856    +1623     
===========================================
+ Hits         20537    22625    +2088     
+ Misses       10696    10231     -465     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 63b210a into gz-sim8 Oct 4, 2024
11 of 12 checks passed
@iche033 iche033 deleted the worldpose_check branch October 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants