Skip to content

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 16, 2024

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1186

Summary

Added Windows install instructions.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <peci1@seznam.cz>
@peci1 peci1 requested a review from mabelzhang as a code owner September 16, 2024 13:45
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 16, 2024
@peci1
Copy link
Contributor Author

peci1 commented Sep 16, 2024

Also, the headings for Ubuntu say Ubuntu 20.04+. However, I don't think that platform is supported for Ionic...

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise, LGTM!

Signed-off-by: Martin Pecka <peci1@seznam.cz>
@azeey azeey merged commit 0e1f254 into gazebosim:gz-sim9 Sep 16, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

gz-sim: Installation

2 participants