Skip to content

Fix log playback GUI display #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Fix log playback GUI display #2611

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a21ad9
Fix log playback GUI display
azeey Sep 10, 2024
ecbcd6b
Merge branch 'gz-sim9' into fix_log_playback
arjo129 Sep 12, 2024
dad1d9f
Add comment about loading logging plugins
azeey Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/SimulationRunner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,8 +1596,6 @@ void SimulationRunner::CreateEntities(const sdf::World &_world)
this->entityCompMgr.ProcessRemoveEntityRequests();
this->entityCompMgr.ClearRemovedComponents();

this->LoadLoggingPlugins(this->serverConfig);

// Load any additional plugins from the Server Configuration
this->LoadServerPlugins(this->serverConfig.Plugins());

Expand Down Expand Up @@ -1653,6 +1651,11 @@ void SimulationRunner::CreateEntities(const sdf::World &_world)
}

this->LoadServerPlugins(defaultPlugins);
// Load logging plugins after all server plugins so that necessary
// plugins such as SceneBroadcaster are loaded first. This might be
// a bug or an assumption made in the logging plugins.
this->LoadLoggingPlugins(this->serverConfig);

};

// Store the initial state of the ECM;
Expand Down
Loading