Skip to content

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 9, 2024

🦟 Bug fix

Summary

Automatically run the gz server (-r) so that readers are not surprised by no output from the simulator.

Added DISPLAY= to commands to ensure the code is not using an X server.

Changed gz topic -et to gz topic -ft to not overload the user's console with binary streams.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@j-rivero
Copy link
Contributor

j-rivero commented Sep 9, 2024

Thanks Martin for the PR. Do you think that would be a good idea to include @iche033 suggestions for checking that EGL is working in this tutorial gazebosim/gazebo_test_cases#1182 (comment) ? Could be a good way of knowing that there is no huge problems without running the camera rendering.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1
Copy link
Contributor Author

peci1 commented Sep 9, 2024

Good idea. Added.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks!

@j-rivero j-rivero merged commit 96775c8 into gazebosim:gz-sim9 Sep 9, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants