Skip to content

Conversation

shameekganguly
Copy link
Contributor

@shameekganguly shameekganguly commented Oct 6, 2025

🦟 Bug fix

Summary

Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR.

  • Remove archive_override for gz-utils dep and used Jetty package from BCR instead. As a result, bazel CI will use released versions of gz deps, which is consistent with cmake CI.
  • Drop repo_name, which removes the need to patch MODULE.bazel when pushing a release to BCR. repo_name is not a required field and can be added on the client side during import if needed to disambiguate packages.
  • Add back buildifier rules to keep bazel files formatted consistently. This also requires importing cc_* rules from rules_cc since native repo rules will be flagged as warning in bazel 8 and dropped completely in bazel 9.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@shameekganguly shameekganguly requested a review from iche033 October 6, 2025 19:46
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 6, 2025
@shameekganguly shameekganguly changed the title Update MODULE.bazel [bazel] Update MODULE.bazel Oct 6, 2025
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@shameekganguly shameekganguly merged commit 77f7c04 into gz-math9 Oct 6, 2025
13 checks passed
@shameekganguly shameekganguly deleted the shameek/bcr_prework branch October 6, 2025 23:32
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 6, 2025
@scpeters
Copy link
Member

scpeters commented Oct 8, 2025

I didn't include this in the cherry-pick forward to main in #699 since it changes the gz-utils dependency to a tarball rather than building from main. Do you think the other changes are separable?

shameekganguly added a commit that referenced this pull request Oct 9, 2025
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@shameekganguly
Copy link
Contributor Author

I didn't include this in the cherry-pick forward to main in #699 since it changes the gz-utils dependency to a tarball rather than building from main. Do you think the other changes are separable?

@scpeters I created a manual forward port in #700 since we want to keep using gz deps from HEAD on the main branches for CI.

shameekganguly added a commit that referenced this pull request Oct 9, 2025
The change had to be amended to apply it on main. Specifically, the repo archive_override in MODULE.bazel for gz-utils was removed in that PR on gz-math9, but we want to preserve it on main to ensure CI uses gz deps from HEAD.

Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants