Skip to content

Conversation

bill997
Copy link
Contributor

@bill997 bill997 commented Apr 21, 2025

Summary

Fix compatibility with protobuf v30 (cpp 6.30.0) - similar to gz-msgs #499

Checklist

  • [ x] Signed all commits for DCO
  • [ n/a] Added tests
  • [ n/a] Updated documentation (as needed)
  • [ n/a] Updated migration guide (as needed)
  • [n/a ] Consider updating Python bindings (if the library has them)
  • [ x] codecheck passed (See contributing)
  • [ x] All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port <FROM_BRANCH> to <TO_BRANCH>

Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

… #499

Signed-off-by: bill ross <4451962+bill997@users.noreply.github.com>
@bill997 bill997 requested a review from nkoenig as a code owner April 21, 2025 07:15
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Apr 21, 2025
@scpeters
Copy link
Member

there was a bug on the main branch that caused a build failure and has just been fixed. Can you merge with main and push to try CI again?

@bill997
Copy link
Contributor Author

bill997 commented Apr 21, 2025

sorry, probably something i did or didn't do.
I'm still getting build errors on main, missing dependencies for gz-transport, gz-gui and gz-sim
i'm using gz-cmake4 (gz-ionic is installed) - have i missed something?
thanks
bill

@scpeters
Copy link
Member

sorry, probably something i did or didn't do. I'm still getting build errors on main, missing dependencies for gz-transport, gz-gui and gz-sim i'm using gz-cmake4 (gz-ionic is installed) - have i missed something? thanks bill

we have been changing which versions are used in Jetty, and these versions were all updated recently

for Ubuntu, if you install the gz-jetty nightly debian package, that should install all the current versions of dependencies

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 22, 2025
@scpeters
Copy link
Member

thanks for your contribution!

@scpeters scpeters merged commit e28e2f5 into gazebosim:main Apr 22, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants