Skip to content

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebo-tooling/release-tools#1244.

Summary

This removes the major version from the package name in the following places:

  • cmake project name
  • package.xml name

An additional change was needed to resolve a name collision between cmake targets. In Ionic, the core library target name is gz-launch8, and the executable implementing the gz launch command has a target name of gz-launch. Removing the major version from the cmake project changes the core library target name to gz-launch, causing a name collision. To resolve this, the executable target name is changed, while setting its OUTPUT_NAME property to gz-launch to retain the same output file name.

Test it

  • Check CI results

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Update cmake project name, package.xml name
* Change gz-launch executable target name to avoid
  conflict with library target name. Set the
  OUTPUT_NAME property to retain same executable
  file name.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

windows build is unhappy since it doesn't find gz-launch9 in the workspace; we would need to update our build scripts to handle package names without a major version, which shouldn't be too hard since we already have logic for supporting gz- and ignition- prefixes

@scpeters
Copy link
Member Author

scpeters commented Mar 19, 2025

@osrf-jenkins run tests please

1 similar comment
@scpeters
Copy link
Member Author

@osrf-jenkins run tests please

@github-project-automation github-project-automation bot moved this from In progress to In review in Core development Mar 25, 2025
@j-rivero j-rivero merged commit 6c6cbe0 into main Mar 25, 2025
9 checks passed
@j-rivero j-rivero deleted the scpeters/package_name_without_major_version branch March 25, 2025 19:00
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants