Disable shadows when viewing point cloud markers #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The markers displayed by the Point Cloud widget cast shadows, which may not be intended.
To reproduce.
gz-gui/examples/standalone/point_cloud
.Before
After
The change adds a default material to the marker message. This triggers the
MarkerManager
system to handle the material, and theSetMaterial
method for markers in the render engine disables shadow casting.There is also a small change to the
CMakeLists.txt
in the point cloud example to allow it to be built on macOS (Darwin).Checklist
codecheck
passed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.