Skip to content

Conversation

srmainwaring
Copy link
Contributor

@srmainwaring srmainwaring commented Oct 17, 2025

🦟 Bug fix

Summary

The markers displayed by the Point Cloud widget cast shadows, which may not be intended.

To reproduce.

  • Run a point cloud publisher, for example by using the executable from gz-gui/examples/standalone/point_cloud.
  • Open an empty world, add the Point Cloud widget, then display the data. Any example world will do provided it includes lighting and a ground plane.

Before

point-cloud-with-shadow

After

point-cloud-no-shadow

The change adds a default material to the marker message. This triggers the MarkerManager system to handle the material, and the SetMaterial method for markers in the render engine disables shadow casting.

There is also a small change to the CMakeLists.txt in the point cloud example to allow it to be built on macOS (Darwin).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
- Allow the point cloud standalone example to build on macOS.

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@srmainwaring srmainwaring force-pushed the prs/point-cloud-disable-shadow branch from 5ab9f53 to 69ef9ea Compare October 17, 2025 12:10
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants