Fix return value when download fails #459
Merged
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul K.A <karahul209@gmail.com>
Signed-off-by: Rahul K.A <karahul209@gmail.com>
Signed-off-by: Rahul K.A <karahul209@gmail.com>
Signed-off-by: Rahul K.A <karahul209@gmail.com>
Signed-off-by: Rahul K.A <karahul209@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-fuel-tools10 #459 +/- ##
==================================================
Coverage ? 75.82%
==================================================
Files ? 19
Lines ? 3144
Branches ? 0
==================================================
Hits ? 2384
Misses ? 760
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahcorde
approved these changes
Apr 8, 2025
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
vermaete
added a commit
to vermaete/meta-ros
that referenced
this pull request
Aug 3, 2025
Needed for gz-fuel-tools-vendor [master]{rolling}
1. Migrate bazel build setup to use bzlmod
* [Pull request ros#466](gazebosim/gz-fuel-tools#466)
* [Pull request ros#467](gazebosim/gz-fuel-tools#467)
1. ci: run cppcheck, cpplint, doxygen on noble
* [Pull request ros#462](gazebosim/gz-fuel-tools#462)
1. Fix return value when download fails
* [Pull request ros#459](gazebosim/gz-fuel-tools#459)
1. Fix code documentation spelling (ros#458)
* [Pull request ros#460](gazebosim/gz-fuel-tools#460)
Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
vermaete
added a commit
to vermaete/meta-ros
that referenced
this pull request
Aug 3, 2025
Needed for gz-fuel-tools-vendor [master]{rolling}
1. Migrate bazel build setup to use bzlmod
* [Pull request ros#466](gazebosim/gz-fuel-tools#466)
* [Pull request ros#467](gazebosim/gz-fuel-tools#467)
1. ci: run cppcheck, cpplint, doxygen on noble
* [Pull request ros#462](gazebosim/gz-fuel-tools#462)
1. Fix return value when download fails
* [Pull request ros#459](gazebosim/gz-fuel-tools#459)
1. Fix code documentation spelling (ros#458)
* [Pull request ros#460](gazebosim/gz-fuel-tools#460)
Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Issue number: 349
Summary
Fixed an issue where the download utility returning a success, even if the actual download fails. Main causes appeared to be some seemingly unintended typecasting between
intandgz::fuel_tools::Result, as well as not checking if the result value was actually a success or not.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.