Skip to content

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented May 1, 2025

🦟 Bug fix

Fixes a cleanup comment

Summary

There is a TODO comment suggesting that we use cmake_path(APPEND) when cmake 3.20 is required. Since Ionic uses cmake 3.22.1, we can make this change now.

Contents of gz-cmake4.pc with this branch:

prefix=${pcfiledir}/../../
includedir=${prefix}/include/gz/cmake4

Name: Gazebo cmake
Description: Build system package for the Gazebo libraries
Version: 4.2.0
Requires:
Requires.private:
Libs:
Libs.private:
CFlags: -I${includedir} 

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters force-pushed the scpeters/cmake_path_append branch from 5a68c1b to e1cbc89 Compare May 4, 2025 13:14
@scpeters scpeters marked this pull request as ready for review May 4, 2025 13:15
@scpeters scpeters requested a review from j-rivero as a code owner May 4, 2025 13:15
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 5, 2025
@j-rivero j-rivero merged commit 225d74b into gz-cmake4 May 5, 2025
10 checks passed
@j-rivero j-rivero deleted the scpeters/cmake_path_append branch May 5, 2025 15:43
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants