fix update class add #33
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the class management functionality by implementing local loading state and improving form handling. The changes ensure that individual class operations don't affect the global page loading state while maintaining proper user feedback.
- Introduces local
classActionLoadingstate to isolate loading indicators for class operations - Converts form from submit-based to button-based with keyboard shortcuts for better UX
- Updates all class operations (add, edit, delete) to use the new local loading state
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| name="class-name" | ||
| value={newClass.name} | ||
| onChange={(e) => setNewClass({...newClass, name: e.target.value})} | ||
| onKeyDown={(e) => { if (e.key === 'Enter') { e.preventDefault(); handleAddClass(); } }} |
There was a problem hiding this comment.
The inline event handler should be extracted to a separate function for better readability and reusability. Consider creating a handleKeyDown function that can be shared between the name and description fields.
Copilot uses AI. Check for mistakes.
| rows="2" | ||
| value={newClass.description} | ||
| onChange={(e) => setNewClass({...newClass, description: e.target.value})} | ||
| onKeyDown={(e) => { if (e.key === 'Enter' && !e.shiftKey) { e.preventDefault(); handleAddClass(); } }} |
There was a problem hiding this comment.
This inline event handler duplicates logic from line 180 with slight variation. Extract both handlers to a shared function that accepts a parameter to handle the shift key condition.
Copilot uses AI. Check for mistakes.
| className="btn btn-primary" | ||
| disabled={loading} | ||
| disabled={classActionLoading} | ||
| onClick={(e) => { e.preventDefault(); handleAddClass(); }} |
There was a problem hiding this comment.
The e.preventDefault() call is unnecessary here since this is a button with type=\"button\" and not inside a form context that would cause default submission behavior.
| onClick={(e) => { e.preventDefault(); handleAddClass(); }} | |
| onClick={() => { handleAddClass(); }} |
Copilot uses AI. Check for mistakes.
1 participant
No description provided.