Add proposal for temporary preservation of machines #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
thiyyakat
force-pushed
the
proposal/failed-machine-preserve
branch
from
20d8f8f to
9fbdb30
Compare
gardener-robot
added
the
size/m
unmarshall
requested changes
Sep 23, 2025
etiennnr
reviewed
Sep 24, 2025
ashwani2k
requested changes
Oct 3, 2025
There was a problem hiding this comment.
Thanks for the proposal. I've put some comments, while reading it I felt we have not considered all the personas who can consume this feature.
- Operators who will manipulate the machine/node objects.
- Stakholders who will maniuplate the shoot spec.
- Stakeholder who will manipulate the node objects.
Another dimension which I don't see mentioned is how is this state conveyed as part of shoot status and the dashboard.
thiyyakat
changed the title
Failed machines for diagnosticsFailed machines for diagnostics
thiyyakat
changed the title
Failed machines for diagnostics
thiyyakat
force-pushed
the
proposal/failed-machine-preserve
branch
from
0b621a2 to
849a99d
Compare
thiyyakat
changed the title
aaronfern
reviewed
Oct 15, 2025
| - `machine.CurrentStatus.PreserveExpiryTime` is updated by MCM as $machine.CurrentStatus.PreserveExpiryTime = currentTime+machinePreserveTimeout$ | ||
| - After timeout, the phase is changed to `Terminating`. | ||
| - Number of machines in `Failed:Preserved` phase count towards enforcing `autoPreserveFailedMax`. | ||
| 7. If a failed machine is currently in `Failed:Preserved` and before timeout its VM/node is found to be Healthy, the machine will be moved to `Running`. |
There was a problem hiding this comment.
Should this not be moved to Running:Preserved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a proposal to support the temporary preservation of machines.
The use cases have been discussed here.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: