Skip to content

Conversation

jamand
Copy link

@jamand jamand commented Oct 13, 2025

How to categorize this PR?
/kind enhancement
/platform openstack

What this PR does / why we need it:

Server InternalIPs are now returned on created Machines, so that they may be used by gardenadm bootstrap (GEP-28). This is useful when the already provided hostname field (in the Machine status.addresses) is not resolvable, e.g. due to cloud provider specific settings.

Which issue(s) this PR fixes:
Fixes #321

Special notes for your reviewer:
/cc @timebertt @maboehm

  • Currently relies on gardener/machine-controller-manager@52f840e to avoid container crashes, requires a new release.
  • Added a new test case (to check having a pool with multiple internal IPs) + extended happy path.
  • Tested on own environment (with Garden, multiple Seeds, Shoots on the gardener/gardener v1.128.4 version), using the Medium touch scenario: in a virtual cluster the Machine resource is created and the InternalIP is set in the Machine Status.

Release note:

When calling CreateMachine() the method now returns the internal IPs of the server in the Addresses field. 

Server InternalIPs are returned on created Machines, so that they may
be used by gardenadm bootstrap (GEP-28) in case the already provided hostname
(Machine Status field) is not reachable (cloud provider specific).
@jamand jamand requested review from a team as code owners October 13, 2025 14:17
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2025

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added the needs/review Needs review label Oct 13, 2025
@gardener-robot-ci-3
Copy link
Contributor

Thank you @jamand for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 13, 2025
@timebertt
Copy link
Member

cc @kon-angelo @hebelsan can you help us get a review here?

@kon-angelo
Copy link
Contributor

/assign

Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already looked at the change but forgot to post the review 😅 .

I assume there is no other way to get a more "structured" response from the addresses field. I also had a look at the client but I didn't think anything better.

@kon-angelo
Copy link
Contributor

/needs rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Oct 20, 2025
@jamand
Copy link
Author

jamand commented Oct 21, 2025

@kon-angelo Thanks for the Review! In order to remove the current dependency on this particular commit (already on main) I would need a new (patch) release of https://github.com/gardener/machine-controller-manager. I would then do a rebase.
Can you do that or who should I ask?

Also to your point with the "structured" response from the addresses field: I'm also not super happy about it, here the OpenStack API Reference is equally vague with type "object" and the description consult with OpenStack Networking API for up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension needs/rebase Needs git rebase needs/review Needs review platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GEP-28] Extend CreateMachineResult to include InternalIP

6 participants