-
Notifications
You must be signed in to change notification settings - Fork 29
[GEP-28] Add InternalIPs to CreateMachineResponse #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[GEP-28] Add InternalIPs to CreateMachineResponse #322
Conversation
Server InternalIPs are returned on created Machines, so that they may be used by gardenadm bootstrap (GEP-28) in case the already provided hostname (Machine Status field) is not reachable (cloud provider specific).
Thank you @jamand for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
cc @kon-angelo @hebelsan can you help us get a review here? |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had already looked at the change but forgot to post the review 😅 .
I assume there is no other way to get a more "structured" response from the addresses field. I also had a look at the client but I didn't think anything better.
/needs rebase |
@kon-angelo Thanks for the Review! In order to remove the current dependency on this particular commit (already on main) I would need a new (patch) release of https://github.com/gardener/machine-controller-manager. I would then do a rebase. Also to your point with the "structured" response from the addresses field: I'm also not super happy about it, here the OpenStack API Reference is equally vague with type "object" and the description |
How to categorize this PR?
/kind enhancement
/platform openstack
What this PR does / why we need it:
Server InternalIPs are now returned on created Machines, so that they may be used by gardenadm bootstrap (GEP-28). This is useful when the already provided hostname field (in the Machine
status.addresses
) is not resolvable, e.g. due to cloud provider specific settings.Which issue(s) this PR fixes:
Fixes #321
Special notes for your reviewer:
/cc @timebertt @maboehm
Release note: