Add tests for multiple page response #178
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for pagination in the GCP mock server and test to check that machine listing in the
getVMs
function works correctly when instances are spread across multiple pages.DefaultMockPageSize
variable topkg/gcp/fake/mockserver.go
to control the number of instances per page in mock responseshandleList
function inpkg/gcp/fake/mockserver.go
, now slices theInstances
array based onpageToken
andmaxResults
, and setsNextPageToken
when more items are available.pkg/gcp/machine_controller_util.go
pkg/gcp/machine_controller_test.go
that creates multiple machines, sets a small page size, and verifies that all machines are listed across paginated responsesWhich issue(s) this PR fixes:
Similar to Orphan Safety Controller missing VM's due to large resource query on MCM provider-azure
Release note: