Skip to content

Conversation

@georgibaltiev
Copy link
Contributor

How to categorize this PR?

/area security
/kind cleanup
/platform azure

What this PR does / why we need it:

With the following PR, a migration runnable has been added to the PR, in order to remove RBAC resources that were no longer in use. These migrations were intended to be kept until the release of version 1.55.0.

This PR cleans up the migrations.

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:
NONE

Release note:


@gardener-robot gardener-robot added area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 29, 2025
@github-actions
Copy link
Contributor

This pull request removes temporary migration code that was scheduled for deletion after the v1.55.0 release. The change cleans up logic responsible for purging obsolete ClusterRole and ClusterRoleBinding resources for the machine-controller-manager. This improves code maintainability by removing deprecated code and has no impact on current functionality.

Walkthrough

  • Chore: Removed a one-time migration task from the application startup. This task was responsible for cleaning up obsolete RBAC resources. This is a routine code cleanup that improves maintainability by removing logic that is no longer necessary, with no direct impact on end-users.

Model: gemini-2.5-pro | Prompt Tokens: 1185 | Completion Tokens: 128

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2025
@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2025
@kon-angelo
Copy link
Contributor

@georgibaltiev can this be undrafted now?

@georgibaltiev
Copy link
Contributor Author

I will open the PR for review once version v1.55.0 has been released.

@kon-angelo
Copy link
Contributor

It should be up https://github.com/gardener/gardener-extension-provider-azure/releases/tag/v1.55.0 🤔

@georgibaltiev
Copy link
Contributor Author

Oh, I see now. For some reason v1.54.2 has been marked as latest, so I assumed that v1.55.0 has not been released yet.

@kon-angelo
Copy link
Contributor

We had to make a patch release for the previous version too that came later than v1.55 😅

@georgibaltiev georgibaltiev marked this pull request as ready for review October 7, 2025 06:56
@georgibaltiev georgibaltiev requested a review from a team as a code owner October 7, 2025 06:56
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 7, 2025
@kon-angelo kon-angelo merged commit 82b808f into gardener:master Oct 7, 2025
64 checks passed
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2025
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 7, 2025
@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants