-
Notifications
You must be signed in to change notification settings - Fork 90
Clean up MCM RBAC resources migration logic #1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up MCM RBAC resources migration logic #1304
Conversation
|
This pull request removes temporary migration code that was scheduled for deletion after the v1.55.0 release. The change cleans up logic responsible for purging obsolete Walkthrough
Model: gemini-2.5-pro | Prompt Tokens: 1185 | Completion Tokens: 128 |
|
@georgibaltiev can this be undrafted now? |
|
I will open the PR for review once version v1.55.0 has been released. |
|
Oh, I see now. For some reason v1.54.2 has been marked as latest, so I assumed that v1.55.0 has not been released yet. |
|
We had to make a patch release for the previous version too that came later than v1.55 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area security
/kind cleanup
/platform azure
What this PR does / why we need it:
With the following PR, a migration runnable has been added to the PR, in order to remove RBAC resources that were no longer in use. These migrations were intended to be kept until the release of version 1.55.0.
This PR cleans up the migrations.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
NONE
Release note: