change how FGs are enabled in the extension #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-github-actions
bot
added
the
reviewed/ok-to-test
github-actions
bot
added
needs/ok-to-test
kon-angelo
force-pushed
the
fix-chart-fg
branch
from
a30f70c to
234b7c6
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
github-actions
bot
removed
the
reviewed/ok-to-test
AndreasBurger
previously approved these changes
Sep 23, 2025
kon-angelo
added
the
reviewed/ok-to-test
github-actions
bot
removed
the
reviewed/ok-to-test
hebelsan
reviewed
Sep 23, 2025
|
|
||
| {{- define "topologyAwareRouting.enabled" -}} | ||
| {{- if and .Values.gardener.seed .Values.gardener.seed.spec.settings.topologyAwareRouting.enabled }} | ||
| {{- if ((((((.Values.gardener).seed).spec).settings).topologyAwareRouting)) -}} |
There was a problem hiding this comment.
Is the removal of .enabled intentional?
There was a problem hiding this comment.
Also is it safe this way, or will it error if any intermediate map is missing?
How about?
{{- if (.Values | dig "gardener" "seed" "spec" "settings" "topologyAwareRouting" "enabled" false) }}
There was a problem hiding this comment.
Let me test that suggestion
There was a problem hiding this comment.
just FYI, yes, the original method defaults to empty value (hence false) if an intermediate method is missing
Comment on lines
30
to
32
| {{- range $key, $value := .Values.config.featureGates }} | ||
| {{ $key }}: {{ $value }} | ||
| {{- end }} |
There was a problem hiding this comment.
Although this works it will produce random key order, causing noisy diffs between renders.
Could be resolved by:
{{- range $k := (.Values.config.featureGates | keys | sortAlpha) }}
{{ $k }}: {{ index $.Values.config.featureGates $k }}
{{- end }}
418aea1 to
3bbbabf
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
This update refactors the Helm chart for the Azure provider extension to improve maintainability and flexibility. The logic for evaluating certain settings has been simplified. More significantly, the handling of feature gates is now dynamic, allowing new gates to be added via configuration without requiring template modifications. The example controller registration has been updated to incorporate these chart enhancements. Walkthrough
Model: gemini-2.5-pro | Prompt Tokens: 13672 | Completion Tokens: 156 |
github-actions
bot
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
github-actions
bot
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform azure
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: