Skip to content

Conversation

@kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind technical-debt
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove ForceNatGateway feature gate after the updated announcement by Microsoft

@kon-angelo kon-angelo requested a review from a team as a code owner September 22, 2025 16:57
@gardener-robot gardener-robot added area/control-plane Control plane related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly platform/azure Microsoft Azure platform/infrastructure needs/review Needs review labels Sep 22, 2025
@gardener-github-actions gardener-github-actions bot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 22, 2025
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 22, 2025
@github-actions
Copy link
Contributor

This change reverts the feature that automatically enabled Azure NAT Gateway for new shoot clusters. The ForceNatGateway feature gate, along with the associated admission controller logic and tests, has been removed. This change gives users explicit control over their outbound connectivity configuration by no longer defaulting to enabling a NAT Gateway. Documentation has also been updated to reflect this removal, ensuring guidance is accurate.

Walkthrough

  • Revert: The functionality that automatically enabled Azure NAT Gateway for new shoot clusters has been removed. Users creating new clusters will no longer have a NAT Gateway configured by default and must explicitly define their outbound connectivity solution if needed.
  • Documentation: User guides have been updated to remove mentions of the automatic NAT Gateway feature, ensuring documentation accurately reflects the current cluster creation behavior.

Model: gemini-2.5-pro | Prompt Tokens: 6020 | Completion Tokens: 158

@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2025
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 23, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2025
@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2025
@kon-angelo kon-angelo merged commit 3acf82d into gardener:master Sep 25, 2025
93 checks passed
@kon-angelo kon-angelo deleted the remove-nat-gw-mutator branch September 25, 2025 07:52
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane Control plane related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants