Skip to content

Conversation

@kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kon-angelo kon-angelo requested a review from a team as a code owner September 19, 2025 07:56
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure labels Sep 19, 2025
@kon-angelo kon-angelo requested a review from hebelsan September 19, 2025 07:56
@gardener-robot gardener-robot added the needs/review Needs review label Sep 19, 2025
@github-actions
Copy link
Contributor

This change refines the startup process by correctly scoping a one-time migration task. The cleanup for legacy Terraformer RBAC resources is now nested to ensure it only runs on shoot clusters, not garden clusters. This aligns its behavior with a similar migration for the Machine Controller Manager, making the logic more consistent and preventing unnecessary operations on the garden cluster. The overall functionality for shoot clusters remains unchanged, but the startup sequence is now more precise.

Walkthrough

  • Refactor: The startup logic has been improved to ensure legacy RBAC resource cleanup tasks are correctly scoped. The one-time migration task for cleaning up old Terraformer resources will now only execute for shoot clusters, preventing it from running unnecessarily in the garden cluster context. This enhances the robustness of the extension's startup process.

Model: gemini-2.5-pro | Prompt Tokens: 618 | Completion Tokens: 159

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Sep 19, 2025
@gardener-github-actions gardener-github-actions bot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2025
@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2025
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 19, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2025
@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2025
@hebelsan hebelsan merged commit 5469181 into gardener:master Sep 19, 2025
88 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 19, 2025
@kon-angelo kon-angelo deleted the fix/runtime-permissions branch September 19, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants