[25.0] More fixes to FormData drag and drop and typing

[ahmedhamidawan]

@mvdbeek has pushed a commit that should fix map-over of collection DCEs. Fixes #20315

The rest of these changes (from a while ago 😅) are improvements/fixes for drag and drop as a follow up to changes in #19866.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

We can’t do that, this breaks reruns of mapped over jobs.

[mvdbeek]

That’s not what we discussed in the backend meeting, you can’t allow paired collections in a non-paired input is the issue

[ahmedhamidawan]

That’s not what we discussed in the backend meeting, you can’t allow paired collections in a non-paired input is the issue

But then, if you try a (non DCE) pair as an input here for this, it doesn't error out.

[mvdbeek]

I am not sure I understand this comment ? A DCE representing a list should and does work currently.

[ahmedhamidawan]

Sorry, since you said:

you can’t allow paired collections in a non-paired input is the issue

I tried using a pair as in input to this same tool, and it doesn't produce the error (from Jen's issue). Its only when I try a pair that is inside a collection that this fails.

[mvdbeek]

We're talking about DCEs, so that's what I'm doing. And it works on lists inside of list:list collections.

[ahmedhamidawan]

Ah ok

So it's a particular thing where, on the client we can look for if it's a DCE that is a paired collection, disallow it as a drag and drop input unless that input specifically allows that

[mvdbeek]

That sounds right. The logic should all be there already, since it is the same that's used for hdcas, it's just that you'll likely have to pass along the collection type when you start dragging (as DCEs proper don't have a collection type, that is part of the element_object, however inside the parent you should know what what each member of the collection represents).

[ahmedhamidawan]

We're talking about DCEs, so that's what I'm doing. And it works on lists inside of list:list collections.

I just tried list:list and it produces that error too:

list_list_also_errors.mp4

[mvdbeek]

It works fine on multiple="true" inputs. I would suggest fixing this, instead of removing it.

[mvdbeek]

I've pushed a commit that should fix map-over of collection dces.

[ahmedhamidawan]

Oh nice, so this fixes the bug reported in #20315 as well, because now we successfully accept DCE collections (even pairs!) as valid inputs here:

form_data_various_fixes_2.mp4

If a FormData has explicit collection types, that is already something we check and confirm against even on drag and drop.

So, I will remove the commit now that disallowed DCE collections as inputs (and update the PR description...)

[mvdbeek]

e6755dc definitely needs tests that exercise basic runs with DCEs as well as map over handling.

[ahmedhamidawan]

Good point, I can add backend tests.

[ahmedhamidawan]

I have added an API test, and ensured it tests the case where DCEs are passed as inputs directly. Tested that it breaks without your changes. @mvdbeek