-
Notifications
You must be signed in to change notification settings - Fork 15
Add command to upgrade tests to comply with profile 24.2 validation #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle multiple edits in one request
To comply with profile 24.2 validation of tests
And implement workspace edits to handle multiple edits in a single request
Improve ancestor validation and add element key retrieval
To accept a Set instead of a List and sort parameters before removal to get more consistent results since sets are unordered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #277
This pull request adds a new command (by default, the keybinding is
ctrl+alt+u
) to update test cases to the new validation requirement for tool tests introduced in Galaxy 24.2 and planemo.A bit of context
Suppose we have a tool whose
inputs
section looks as follows:And then we have a test in out tests section declaring params in the following way:
In this case, the tool linting will complain with the following warnings:
How it works
You can now run the extension command using the default key shortcut
ctrl+alt+u
, or search for it in the command palette as shown in the following video:UpdateToolTests.mp4
The command will try to rewrite the params in the test cases to comply with the 24.2 validation profile.