Skip to content

Support different with and without hybrid benefits #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gabrielweyer
Copy link
Owner

@gabrielweyer gabrielweyer commented Aug 9, 2024

  • Support different with and without hybrid benefits instances: some instances are only available with or without hybrid benefits. I initially made the assumption that instances without hybrid benefits were a superset of instances with hybrid benefits. It turned out to be wrong.
  • Discard duplicate VMs: due to what seems to be an operator error, some instance names are duplicated. As I use instance names to identify VMs and match instances, this sort of broke everything. The easiest solution is to discard duplicate instances (later on I might try to discard only the incorrect one(s)). Unfortunately it means that the duplicate instances will be missing (better not to provide any price than an incorrect price).

Example with the F16s v2 instance for the zh-tw culture without hybrid benefits:

image

image

In this example, it's obvious that the second F16s v2 can safely be renamed to L16s v2 but I need to do more analysis to determine if it's always the case.

@gabrielweyer gabrielweyer merged commit 48c10db into main Aug 9, 2024
4 checks passed
@gabrielweyer gabrielweyer deleted the support-different-with-and-without-hybrid-benefits branch August 9, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant