Skip to content

[fj-doc-lib-simpletable-import] migrate junit4 to junit5 #354 #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

[fj-doc-lib-simpletable-import] migrate junit4 to junit5 #354 #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fj-doc-lib-simpletable-import/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>

Expand Down
10 changes: 5 additions & 5 deletions ...c/test/java/test/org/fugerit/java/doc/lib/simpletableimport/TestImportSimpleTableCsv.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@

import org.fugerit.java.doc.lib.simpletableimport.ConvertCsvToSimpleTableFacade;
import org.fugerit.java.doc.mod.poi.XlsxPoiTypeHandler;
import org.junit.Assert;
import org.junit.Test;

import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

@Slf4j
public class TestImportSimpleTableCsv {
class TestImportSimpleTableCsv {

private boolean testXlsxWorker( String inputPath, String outputPath ) {
File inputFile = new File( inputPath );
Expand All @@ -32,8 +32,8 @@ private boolean testXlsxWorker( String inputPath, String outputPath ) {
}

@Test
public void testXlsx() {
Assert.assertTrue( this.testXlsxWorker( "src/test/resources/xlsx/simple_table_01.csv", "target/simple_table_01_csv.xlsx" ) );
void testXlsx() {
Assertions.assertTrue( this.testXlsxWorker( "src/test/resources/xlsx/simple_table_01.csv", "target/simple_table_01_csv.xlsx" ) );
}

}
10 changes: 5 additions & 5 deletions .../test/java/test/org/fugerit/java/doc/lib/simpletableimport/TestImportSimpleTableXlsx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@

import org.fugerit.java.doc.lib.simpletableimport.ConvertXlsxToSimpleTableFacade;
import org.fugerit.java.doc.mod.poi.XlsxPoiTypeHandler;
import org.junit.Assert;
import org.junit.Test;

import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

@Slf4j
public class TestImportSimpleTableXlsx {
class TestImportSimpleTableXlsx {

private boolean testXlsxWorker( String inputPath, String outputPath ) {
File inputFile = new File( inputPath );
Expand All @@ -32,8 +32,8 @@ private boolean testXlsxWorker( String inputPath, String outputPath ) {
}

@Test
public void testXlsx() {
Assert.assertTrue( this.testXlsxWorker( "src/test/resources/xlsx/simple_table_01.xlsx", "target/simple_table_01_xlsx.xlsx" ) );
void testXlsx() {
Assertions.assertTrue( this.testXlsxWorker( "src/test/resources/xlsx/simple_table_01.xlsx", "target/simple_table_01_xlsx.xlsx" ) );
}

}