Skip to content

handle alt text for svg in mod-fop #339 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<#macro handleImage docImage>
<fo:block <@handleAlign alignValue=docImage.align/>>
<#if docImage.svg>
<fo:instream-foreign-object xmlns:svg="http://www.w3.org/2000/svg">${base64ToString(docImage.resolvedBase64)}</fo:instream-foreign-object>
<fo:instream-foreign-object <#if (docImage.alt)??> fox:alt-text="${docImage.alt}" </#if> xmlns:svg="http://www.w3.org/2000/svg">${base64ToString(docImage.resolvedBase64)}</fo:instream-foreign-object>
<#else>
<#if (docImage.scaling)??>
<#assign imageScaling="height='${docImage.scaling}%' content-height='${docImage.scaling}%' content-width='scale-to-fit' scaling='uniform' width='${docImage.scaling}%'"/>
Expand Down
4 changes: 2 additions & 2 deletions fj-doc-mod-fop/src/test/resources/sample/doc_alt_01.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<doc xmlns="http://javacoredoc.fugerit.org"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://javacoredoc.fugerit.org https://www.fugerit.org/data/java/doc/xsd/doc-1-10.xsd">
xsi:schemaLocation="http://javacoredoc.fugerit.org https://www.fugerit.org/data/java/doc/xsd/doc-2-1.xsd">
<metadata>
<info name="margins">10;10;10;30</info>
<info name="table-border-collapse">collapse</info>
Expand All @@ -10,7 +10,7 @@
</metadata>
<body>
<h head-level="1">Alternative sample doc</h>
<para><image type="svg" scaling="50" alt="Test SGV"
<para><image type="svg" alt="Test SGV"
base64="PHN2ZyBoZWlnaHQ9IjEwMHB4IiB3aWR0aD0iMTAwcHgiIHZlcnNpb249IjEuMSIgaWQ9IkxheWVyXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIAoJIHZpZXdCb3g9IjAgMCA1MTIuMDAxIDUxMi4wMDEiIHhtbDpzcGFjZT0icHJlc2VydmUiPgo8Zz4KCTxwYXRoIHN0eWxlPSJmaWxsOiNGRkM4NTU7IiBkPSJNMjU2Ljk1NSwwLjA1bC03MS41Niw0NTguOTQ1TDEyLjA2OSw0ODIuNjNjLTguNjMxLDEuMTc3LTE0LjkyNi03Ljk3MS0xMC43NDMtMTUuNjExTDI1Ni45NTUsMC4wNXoKCQkiLz4KCTxwYXRoIHN0eWxlPSJmaWxsOiNGRkM4NTU7IiBkPSJNMjU2Ljk1NSwwLjA1bDc4LjQ4LDQ1OC45NDVsMTY0LjQzLDIzLjQ5YzguNjM5LDEuMjM1LDE0Ljk5Mi03LjkwNiwxMC44MjUtMTUuNTczTDI1Ni45NTUsMC4wNXoiLz4KPC9nPgo8cG9seWdvbiBzdHlsZT0iZmlsbDojRkFBRjUwOyIgcG9pbnRzPSIyNTYuOTU1LDAuMDUgMjU2Ljk1NSw1MTEuOTUxIDMzNS40MzQsNDU4Ljk5NiAiLz4KPHBvbHlnb24gc3R5bGU9ImZpbGw6I0ZGRTE4MjsiIHBvaW50cz0iMjU2Ljk1NSwwLjA1IDE4NS4zOTQsNDU4Ljk5NiAyNTYuOTU1LDUxMS45NTEgIi8+Cjwvc3ZnPg=="/>
</para>
<table space-before="30" columns="3" colwidths="30;30;40" id="excel-table" padding="2" width="100">
Expand Down