Skip to content

Conversation

simonostendorf
Copy link
Member

Closes #129

@simonostendorf simonostendorf self-assigned this Oct 9, 2025
@simonostendorf simonostendorf requested a review from Copilot October 9, 2025 21:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the Laravel Octane server from FrankenPHP to RoadRunner as part of implementing roadrunner devcontainer support. The changes update configuration files to use RoadRunner instead of FrankenPHP as the default Octane server.

  • Updates default Octane server configuration from FrankenPHP to RoadRunner
  • Comments out FrankenPHP-specific Docker configuration settings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docker-compose.sail.yaml Comments out FrankenPHP-specific supervisor and XDG environment variables
.env.example Changes default OCTANE_SERVER from frankenphp to roadrunner

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@simonostendorf simonostendorf force-pushed the feat/roadrunner-devcontainer branch from 0e10106 to 848d723 Compare October 16, 2025 23:06
@simonostendorf simonostendorf merged commit c84f556 into dev Oct 16, 2025
2 checks passed
@simonostendorf simonostendorf deleted the feat/roadrunner-devcontainer branch October 16, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants