Issue #279: Fix FSharpFunc unit type args #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Jun 27, 2019
|
Could you add a corresponding test case for this please? THanks |
|
Added some tests. Also there's a skipped test for #323. |
dsyme
approved these changes
Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279
Problem is
emitLambdarelies onbody.Typeto build theFSharpFunctype.body.Typein the case of a_ -> unitfunction isSystem.Voidso the type getting built isFSharpFunc<_,void>. Meanwhile a function of the formunit -> _is fine since the first type argument uses the type of the lambda var.I resorted to using
FullNameon the generic type definitions to check forFSharpFunctype, maybe there's a better way?