Implemented support for optional properties usage in non-Enumerable LINQ queries #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VectorTetra
force-pushed
the
queryable-cast
branch
from
6194694 to
18d8dac
Compare
VectorTetra
force-pushed
the
queryable-cast
branch
from
18d8dac to
88ad982
Compare
xperiandri
requested changes
May 7, 2025
xperiandri
approved these changes
May 8, 2025
xperiandri
changed the title
xperiandri
changed the title
valbers
reviewed
May 8, 2025
| else | ||
| let t = value.GetType() | ||
| if t.FullName.StartsWith ReflectionHelper.OptionTypeName then | ||
| let p = t.GetProperty("Value") |
There was a problem hiding this comment.
why isn't there a test for if the value is a None like in the ValueOption case (ValueNone)? I mean:
if value = Activator.CreateInstance t then None?
Is it intentional?
There was a problem hiding this comment.
It is a check for ValueOption.None. As it is a value type it's instance is empty struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.