Support for Livestreaming via local TCP proxy server #1051
Conversation
|
For now this PR just serves as a status tracker for the example shown in #343 (comment). |
|
@fronzbot hey, do you think this could be merged without tests for the livestreaming part or do you want a mock for that? |
mback2k
changed the title
|
My preference is for tests to be included for new methods/classes. Far too often something has changed on Blink's end resulting in a library change that borks some code that we weren't unittesting. Better to get in front of that IMO. Is this ready for review? I see you changed the title but it's still marked as a draft. |
|
It is missing tests right now, but I will try to add some for the new API. Not sure about the livestream itself though. |
| """Stop the stream.""" | ||
| # Close all connections | ||
| _LOGGER.debug("Stopping server, closing connections") | ||
| if self.server and not self.server.is_serving(): |
There was a problem hiding this comment.
Shouldn't the closing be done when the server is serving?
if self.server and self.server.is_serving():
|
Hi @mback2k - this has been open for awhile now and still marked as a Draft. Is this ready for review yet? |
I am sorry, I was sick recently. I will try to get back to this soon, but for now tests are still missing and the stream connection is also not fully reliable yet, I guess because not all parameters in the authentication frames ware correctly decoded yet. |
Description:
Support livestreaming based on the work described in #343:
Related issue (if applicable): fixes #343
Checklist:
toxrun successfully PR cannot be meged unless tests pass