Migrated from interfaces to types. Added support for environment variable default component directory. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types are easier to work with as opposed to interfaces (unions, can define types that aren't an object, and will override previously defined types of the same name rather than extending them)
The output directory that the Svelte icon components get placed into can be set by the environment variable SVELICON_ICON_PATH
Removed the rouge src/icons folder
|
I love the idea for your library, and I had a few ease of life changes. Let me know what you think! |
|
Thanks for the PR @Tyler-Petrov . Can I know the reason for change interfaces to types? |
|
I find types easier to work with using unions and intersections. I feel like most people are using types more exclusively over types and interfaces, so it seemed like a good change to make. There also really isn't a speed difference between types and interfaces anymore. I guess it is more of a personal preference thing, but it does seem to impact the real world albeit in a small way. P.S. I have a few other ideas as well for making the package more customizable, so I'll probably submit another PR in the not to distant future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all interfaces to types (read commit message for details).
Added support for setting a default icon component directory using the environment variable SVELICON_ICON_PATH.