Skip to content

Drop support for MV2 Chrome #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,9 @@ jobs:
Test:
# https://github.com/puppeteer/puppeteer/issues/12818#issuecomment-2415915338
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
permission:
- tabs
- webNavigation
version:
- "2"
- "3"
steps:
- uses: actions/checkout@v3
- run: sudo apt-get install xvfb
- run: npm ci
- run: npm run demo:build
- name: Use tabs-only permission
if: matrix.permission == 'tabs'
run: |
sed -i 's/webNavigation/tabs/' test/demo-extension/mv${{ matrix.version }}/manifest.json
- run: xvfb-run --auto-servernum npm run jest:core
env:
TARGET: ${{ matrix.version }}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No MV2, no Firefox tests:

So I'm dropping MV2 tests altogether

14 changes: 1 addition & 13 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Demo extension

There's a demo extension in both MV2 (manifest v2) and MV3 (manifest v3) variants. This extension can be build and run manually, via `web-ext` or as a test fixture.
There's a demo MV3 (manifest v3) extension. This extension can be built and run manually, via `web-ext` or as a test fixture.

### Building the extension locally

Expand All @@ -13,23 +13,12 @@ npm run demo:build
npm run demo:watch
```

Both MV2 and MV3 versions will be built at the same time

### Running Jest tests

```sh
npm run jest
```

Both MV2 and MV3 versions will be tested in series.

Or pick one:

```sh
TARGET=2 npm run jest:core
TARGET=3 npm run jest:core
```

### Running the demo extension locally

```sh
Expand All @@ -39,4 +28,3 @@ npx web-ext run
You can add these flags to `web-ext`:

- `-t chromium` to open Chrome
- `--sourceDir test/dist/mv3` to open the Manifest v3 version instead of v2
3 changes: 1 addition & 2 deletions jest-puppeteer.config.cjs
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
const path = require('node:path');
const process = require('node:process');

module.exports = {
launch: {
headless: false,
args: [
'--disable-extensions-except=' + path.resolve(__dirname, 'test/dist/mv' + (process.env.TARGET ?? 2)),
'--disable-extensions-except=' + path.resolve(__dirname, 'test/dist'),
'--window-size=400,800',
],
},
Expand Down
Loading