Skip to content

Conversation

patmaddox
Copy link
Contributor

e37cf98 changed pkg update to only update FreeBSD repo. 14.3 now ships with two repos configured - FreeBSD and FreeBSD-kmods. Later calls to pkg rquery and pkg fetch failed with this multi-repo configuration.

e37cf98 changed `pkg update` to only update FreeBSD repo. 14.3 now
ships with two repos configured - FreeBSD and FreeBSD-kmods. Later
calls to `pkg rquery` and `pkg fetch` failed with this multi-repo
configuration.
@dch
Copy link
Contributor

dch commented Jun 28, 2025

LGTM @patmaddox how would this interact with #1025 where the url used introduces a different pkg repo?

(IMO this bug you've reported here should be fixed first)

@michael-o
Copy link
Contributor

LGTM @patmaddox how would this interact with #1025 where the url used introduces a different pkg repo?

(IMO this bug you've reported here should be fixed first)

Exactly my question!

@patmaddox
Copy link
Contributor Author

LGTM @patmaddox how would this interact with #1025 where the url used introduces a different pkg repo?

(IMO this bug you've reported here should be fixed first)

Good question. I don't know, because I haven't tested it.

Based on my understanding of things, it would at least be able to pass the rquery stage. However, the config written is pretty simple: it just writes the URL. So if the URL needs SRV records, or the repo uses a signing key that isn't acceptable to this jail, then I would expect install to fail.

Basically, this PR just addresses the fact that -b is completely broken on a brand new 14.3 jail, because 14.3 introduces a second repo into the default config.

poudriere makes a lot of assumptions regarding configuration, particularly around pre-fetching packages. More work would need to be done to support more varied configurations.

For example, I had previously patched common.sh so that I can fetch from one of my repos and reuse packages across ABI-compatible jails:

        cat >> "${MASTERMNT:?}/etc/pkg/poudriere.conf" <<-EOF
        FreeBSD: {
                url: "${packagesite}",
                mirror_type: "none",
                signature_type: "none"
        }
        EOF

@karolyi
Copy link

karolyi commented Jul 3, 2025

Hey,

just applied this patch individually on my poudriere-devel, and can confirm it started to fetch existing packages again.

@karolyi
Copy link

karolyi commented Jul 3, 2025

Also, not sure if it counts but I use a PACKAGE_FETCH_URL=http://my-packagemirror-url/\${ABI} setting in poudriere.conf.

@ELDiablO59152
Copy link

I patched mine has well and please can you fix the typo at : https://github.com/freebsd/poudriere/pull/1228/files#diff-afbea33008c9478b94f3379278925c57204b3283411000094ee48d2388293a5fL4491

msg "Packge fetch: bootstrapping pkg"

dsh2dsh added a commit to dsh2dsh/poudriere that referenced this pull request Aug 2, 2025
dsh2dsh added a commit to dsh2dsh/freebsd-ports that referenced this pull request Aug 2, 2025
@bdrewery bdrewery self-assigned this Aug 4, 2025
@bdrewery bdrewery added this to the 3.4.4 milestone Aug 4, 2025
@patmaddox
Copy link
Contributor Author

LGTM @patmaddox how would this interact with #1025 where the url used introduces a different pkg repo?

(IMO this bug you've reported here should be fixed first)

#1239 answers it: either overwrite the FreeBSD config entirely with no checking, or disable it and parameterize the repo name throughout

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Aug 18, 2025
This update includes a fix from freebsd/poudriere#1228
freebsd/poudriere#1228

download_from_repo: Only query and fetch from FreeBSD repo

Changelog:
dsh2dsh/poudriere@3.4.99.20250725...3.4.99.20250802

PR:		288610
Approved by:	yuri@ (Mentor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants