Skip to content

Remove the "::" separator from the SEPARATORS_REGEXP in searcher.js #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaitanyarahalkar
Copy link
Contributor

@chaitanyarahalkar chaitanyarahalkar commented Mar 31, 2025

Should fix #2463

Tried searching for std::min and was able to get good C++ documentation results.

The issue was in the search query normalization process. When you searched for "std::min", the "::" (scope resolution operator in C++) was being replaced with a separator character, which prevented the search from matching C++ symbols correctly.

I removed the "::" pattern from the SEPARATORS_REGEXP regular expression in the searcher.js file. This change allows the search functionality to preserve the C++ scope resolution operator (::) when processing search queries.

@chaitanyarahalkar chaitanyarahalkar requested a review from a team as a code owner March 31, 2025 00:27
@chaitanyarahalkar
Copy link
Contributor Author

@simon04 let me know if this change looks good. Ty!

@simon04
Copy link
Contributor

simon04 commented Apr 18, 2025

Hi, thank you for this PR. I have troubles understanding the practical benefit when not considering :: as a separator. The given example std::min works just fine at the moment? Are there other search inputs that benefit from removing :: as a separator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching C++ doc by URL is broken
2 participants