Repayment schedule rewrite (exact monthly repayments for repay over fixed number of periods) + optional rounding off of repayment amount in repayment schedule #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-bokya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkbox in Loan Product to configure whether to round off (ceil, actually) monthly repayments or not.
Before the option is checked:
After:
Resolves #31
Edit: This started out as a minor fix to the repayment amount in response to #31, but is now far bigger in scope as previously all repayment schedules used the PMT formula and, as a result, the monthly repayment amount came out to be somewhat incorrect.
This PR also attempts to use one single function to calculate interest amounts everywhere.