fix(webform): remove non-existent company field from Student Applicant #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
companyfield from the Student Applicant web form.The field was introduced in commit [4f8667b] , but it does not exist in the underlying Student Applicant DocType.
As a result, editing or saving the web form currently throws an error:
This patch aligns the web form with the current DocType and resolves the error reported by users.
If the maintainers feel that Student Applicant should indeed have a
companyfield, please let me know — I’ll be happy to add it to the DocType in a follow-up PR instead of removing it here.Steps to Reproduce the Bug:
Fix:
Removed the non-existent
companyfield fromstudent_applicant.jsonweb form definition.no-docs