Skip to content

fix(create-frames): move eslint config to cjs, fix eslint errors, use minor versions of nextjs #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

fix(create-frames): move eslint config to cjs, fix eslint errors, use minor versions of nextjs #371

merged 1 commit into from
May 8, 2024

Conversation

michalkvasnicak
Copy link
Collaborator

@michalkvasnicak michalkvasnicak commented May 7, 2024 •
edited
Loading

Change Summary

This PR:

  • fixes eslint configurations by moving them to cjs
  • fixes eslint errors
  • changes allowed next version to accept minor upgrades (templates now work again since next@14.2.3 has been released)

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 7:57am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 7:57am
framesjs-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 7:57am

@michalkvasnicak michalkvasnicak self-assigned this May 7, 2024
@michalkvasnicak michalkvasnicak removed the request for review from stephancill May 7, 2024 07:36
@michalkvasnicak michalkvasnicak marked this pull request as draft May 7, 2024 07:36
@michalkvasnicak michalkvasnicak changed the title fix(create-frames): next template eslint configs and eslint fixes fix(create-frames): move eslint config to cjs, fix eslint errors, use minor versions of nextjs May 7, 2024
@michalkvasnicak michalkvasnicak marked this pull request as ready for review May 7, 2024 07:53
@michalkvasnicak
Copy link
Collaborator Author

@stephancill I was also thinking of upgrading next in debugger to 14.2.3 but in case of debugger the build fails on metadata collection from /hub/v1/validateMessage not sure why this happens, so I decided to keep the debugger untouched for now.

@stephancill stephancill merged commit 4787c9a into dev May 8, 2024
8 checks passed
@stephancill stephancill deleted the fix/next-templates branch May 8, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephancill stephancill stephancill approved these changes

Assignees

@michalkvasnicak michalkvasnicak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkvasnicak @stephancill