Skip to content

feat(debugger): fallback to hosted signer #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

michalkvasnicak
Copy link
Collaborator

Change Summary

This PR adds a fallback to hoster signer in case no signer url nor fid and mnemonic are provided.

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 6:13am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 6:13am
framesjs-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 6:13am

Copy link
Contributor

@stephancill stephancill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this. lgtm once typos are sorted

@stephancill stephancill merged commit e259432 into dev May 8, 2024
8 checks passed
@stephancill stephancill deleted the feat/fallback-to-hosted-signer branch May 8, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants