Skip to content

fix(debugger): correctly render frame error messages #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024

Conversation

michalkvasnicak
Copy link
Collaborator

@michalkvasnicak michalkvasnicak commented May 2, 2024

Change Summary

This PR fixes error message in frame preview.

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 8:55am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 8:55am
framesjs-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 8:55am

@stephancill
Copy link
Contributor

i don't think the updated behaviour is quite right.

below is a screenshot of an error response - it's not clear that it's an error (looks like a normal message)

Screenshot 2024-05-05 at 16 47 25

here is a screenshot of a cast action response, there is no frame context associated with a cast action message response so it doesn't make sense to show it over a frame

Screenshot 2024-05-05 at 16 54 58

@michalkvasnicak
Copy link
Collaborator Author

michalkvasnicak commented May 6, 2024

i don't think the updated behaviour is quite right.

below is a screenshot of an error response - it's not clear that it's an error (looks like a normal message)

Screenshot 2024-05-05 at 16 47 25 here is a screenshot of a cast action response, there is no frame context associated with a cast action message response so it doesn't make sense to show it over a frame Screenshot 2024-05-05 at 16 54 58

@stephancill I wasn't sure how should error message look like since the original implementation that was handling request errors wasn't looking like error either. I will change the styling to be of red color.

@michalkvasnicak
Copy link
Collaborator Author

@stephancill I changed the text color to red, added inline version of error message if there is no image and also used the error message for the rest of errors we have there.

chore: remove unused variable

chore: use type

fix: render error message in red color

fix: render message inline if there is no message
@michalkvasnicak michalkvasnicak force-pushed the feat/debugger-improvements branch from f451de1 to fda3136 Compare May 8, 2024 08:45
@stephancill
Copy link
Contributor

@michalkvasnicak i've added an error and info message variant to help disambiguate the two
Screenshot 2024-05-08 at 10 47 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants