-
Notifications
You must be signed in to change notification settings - Fork 103
fix(debugger): correctly render frame error messages #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@stephancill I wasn't sure how should error message look like since the original implementation that was handling request errors wasn't looking like error either. I will change the styling to be of red color. |
89a8e54
to
4db7d08
Compare
@stephancill I changed the text color to red, added inline version of error message if there is no image and also used the error message for the rest of errors we have there. |
4db7d08
to
f451de1
Compare
chore: remove unused variable chore: use type fix: render error message in red color fix: render message inline if there is no message
f451de1
to
fda3136
Compare
@michalkvasnicak i've added an error and info message variant to help disambiguate the two |
Change Summary
This PR fixes error message in frame preview.
Merge Checklist