chore(10027-cheatcode-mutability-tags): Fix Mutability Tags for Cheatcodes that are Missing Them #10351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opening this as a draft to track work and get feedback.
This draft PR begins addressing issue #10027 — reviewing and updating
view
/pure
/external
modifiers for cheatcodes that do not modify EVM state.Plan
external
with noview
orpure
modifierview
pure
Note
Ran
cargo check
,cargo clippy
, andcargo +nightly fmt --check
, all passed.Ran
cargo test --all --all-features
multiple times and observed inconsistent failures across different tests.To verify test isolation, ran:
cargo test --all --all-features -- --test-threads=1
.With this, previously failing tests (like
decode_traces_with_project_artifacts
) passed, possibly indicating test suite flakiness.Motivation
Solution
PR Checklist