chore(forge-script): use join_all #10309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkysg
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Apr 15, 2025
Comment on lines
+241
to
+242
| for verification in join_all(future_verifications).await { | ||
| match verification { |
There was a problem hiding this comment.
I think this is currently done as a naive back-off to make sure we don't spam the verify endpoint considering that is the most common failure.
There was a problem hiding this comment.
the original code only prints an error log when verification fails but still proceeds to verify the next item
There was a problem hiding this comment.
yeah but this could spam an already fragile endpoint, i don't think we should do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist