feat(10027-cheatcode-mutability-tags): getrecordedlogs and getwallets are external view

Author: Mouzayan

crates/cheatcodes/assets/cheatcodes.json

@@ -909,7 +909,7 @@ interface Vm {
 
     /// Gets all the recorded logs.
     #[cheatcode(group = Evm, safety = Safe)]
-    function getRecordedLogs() external returns (Log[] memory logs);
+    function getRecordedLogs() external view returns (Log[] memory logs);
 
     // -------- Gas Metering --------
 
@@ -2244,7 +2244,7 @@ interface Vm {
 
     /// Returns addresses of available unlocked wallets in the script environment.
     #[cheatcode(group = Scripting)]
-    function getWallets() external returns (address[] memory wallets);
+    function getWallets() external view returns (address[] memory wallets);
 
     // ======== Utilities ========
 

crates/cheatcodes/spec/src/vm.rs

@@ -2259,7 +2259,7 @@ forgetest_init!(can_get_script_wallets, |prj, cmd| {
 import "forge-std/Script.sol";
 
 interface Vm {
-    function getWallets() external returns (address[] memory wallets);
+    function getWallets() external view returns (address[] memory wallets);
 }
 
 contract WalletScript is Script {
@@ -2576,13 +2576,13 @@ Chain 31337
 accessList           []
 chainId              31337
 gasLimit             228247
-gasPrice             
+gasPrice
 input                [..]
-maxFeePerBlobGas     
-maxFeePerGas         
-maxPriorityFeePerGas 
+maxFeePerBlobGas
+maxFeePerGas
+maxPriorityFeePerGas
 nonce                0
-to                   
+to
 type                 0
 value                0
 
@@ -2591,11 +2591,11 @@ value                0
 accessList           []
 chainId              31337
 gasLimit             93856
-gasPrice             
+gasPrice
 input                0x7357f5d2000000000000000000000000000000000000000000000000000000000000007b00000000000000000000000000000000000000000000000000000000000001c8
-maxFeePerBlobGas     
-maxFeePerGas         
-maxPriorityFeePerGas 
+maxFeePerBlobGas
+maxFeePerGas
+maxPriorityFeePerGas
 nonce                1
 to                   0x5FbDB2315678afecb367f032d93F642f64180aa3
 type                 0

crates/forge/tests/cli/script.rs

@@ -47,8 +47,8 @@ Mark `view`:
 - [x] `getMappingLength`: `getMappingLength(address,bytes32)` _suggested: `view`_
 - [x] `getMappingSlotAt`: `getMappingSlotAt(address,bytes32,uint256)` _suggested: `view`_
 - [ ] `getNonce_1`: `getNonce(address,uint256,uint256,uint256)`
-- [ ] `getRecordedLogs`: `getRecordedLogs()`
-- [ ] `getWallets`: `getWallets()`
+- [x] `getRecordedLogs`: `getRecordedLogs()` _suggested: `view`_
+- [x] `getWallets`: `getWallets()` _suggested: `view`_
 - [x] `noAccessList`: `noAccessList()` _suggested: `view`_
 - [x] `readCallers`: `readCallers()` _suggested: `view`_