Skip to content

Commit 4c73eaf

Browse files
committed
feat(10027-cheatcode-mutability-tags): noaccesslist and readcallers are external view
1 parent e204659 commit 4c73eaf

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

crates/cheatcodes/assets/cheatcodes.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/cheatcodes/spec/src/vm.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ interface Vm {
571571

572572
/// Utility cheatcode to remove any EIP-2930 access list set by `accessList` cheatcode.
573573
#[cheatcode(group = Evm, safety = Unsafe)]
574-
function noAccessList() external;
574+
function noAccessList() external view;
575575

576576
/// Utility cheatcode to mark specific storage slot as warm, simulating a prior read.
577577
#[cheatcode(group = Evm, safety = Unsafe)]
@@ -695,7 +695,7 @@ interface Vm {
695695

696696
/// Reads the current `msg.sender` and `tx.origin` from state and reports if there is any active caller modification.
697697
#[cheatcode(group = Evm, safety = Unsafe)]
698-
function readCallers() external returns (CallerMode callerMode, address msgSender, address txOrigin);
698+
function readCallers() external view returns (CallerMode callerMode, address msgSender, address txOrigin);
699699

700700
// ----- Arbitrary Snapshots -----
701701

docs/dev/cheatcode-mutability-review.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ Mark `view`:
4949
- [ ] `getNonce_1`: `getNonce(address,uint256,uint256,uint256)`
5050
- [ ] `getRecordedLogs`: `getRecordedLogs()`
5151
- [ ] `getWallets`: `getWallets()`
52-
- [ ] `noAccessList`: `noAccessList()`
53-
- [ ] `readCallers`: `readCallers()`
52+
- [x] `noAccessList`: `noAccessList()` _suggested: `view`_
53+
- [x] `readCallers`: `readCallers()` _suggested: `view`_
5454

5555
---
5656

0 commit comments

Comments
 (0)